feat: type-safe JSON insertions/updates, eb.valJson & sql.valJson.
#1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igalklebanov
added
api
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
igalklebanov
changed the title
Serialized<O>, stricter JSONColumnType<O>, eb.valSerialized & sql.valSerialized.Serialized<O>, stricter JSONColumnType<O> insertions/updates, eb.valSerialized & sql.valSerialized.
igalklebanov
changed the title
Serialized<O>, stricter JSONColumnType<O> insertions/updates, eb.valSerialized & sql.valSerialized.JSONColumnType<O> insertions/updates, eb.valSerialized & sql.valSerialized.
igalklebanov
changed the title
JSONColumnType<O> insertions/updates, eb.valSerialized & sql.valSerialized.JSONColumnType<O> insertions/updates, eb.valSerialized & sql.valSerialized.
igalklebanov
changed the title
JSONColumnType<O> insertions/updates, eb.valSerialized & sql.valSerialized.JSONColumnType<O> insertions/updates, eb.valJson & sql.valJson.
igalklebanov
changed the title
JSONColumnType<O> insertions/updates, eb.valJson & sql.valJson.eb.valJson & sql.valJson.
igalklebanov
force-pushed
the
v0.28
branch
2 times, most recently
from
a84367a to
124c0dc
Compare
igalklebanov
force-pushed
the
stricter-json
branch
from
8e3dbf7 to
a7abe0f
Compare
igalklebanov
force-pushed
the
v0.28
branch
3 times, most recently
from
b2b78db to
ae5cb1e
Compare
igalklebanov
force-pushed
the
stricter-json
branch
from
a7abe0f to
5262c17
Compare
igalklebanov
force-pushed
the
stricter-json
branch
from
5262c17 to
1cda284
Compare
igalklebanov
force-pushed
the
stricter-json
branch
from
1cda284 to
8372531
Compare
…kysely-org#1085) * add reusable helpers recipe and implement missing expression features * force node 22.4.1 in CI because of an npm bug
* feat: add postgres range types (kysely-org#1086) * feat: support refresh naterialized view * fix tests by adding .materialized() to remove the matview * fix failing test * fix: References typo (kysely-org#1092) * chore: refresh-view-node.ts => refresh-materialized-view-node.ts * chore: export node in index.ts --------- Co-authored-by: Isak <[email protected]> Co-authored-by: Jonathan Wu <[email protected]>
Co-authored-by: Igal Klebanov <[email protected]>
introduce ValueNode.serialized. introduce eb.valSerialized. introduce sql.valSerialized. fix json-traversal test suite. fix null handling @ compiler. rename to `valJson`. add instructions in errors. typings test inserts. call the new type `Json` instead, to not introduce a breaking change. add missing json column @ Getting Started. add `appendSerializedValue`.
igalklebanov
force-pushed
the
stricter-json
branch
from
8372531 to
fff673a
Compare
|
Open in Stackblitz • kysely_koa_example commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋
This PR deprecates
JSONColumnType, and introduces the stricterJsontype that enforces type-safe insertions/updates.Using a branded type as the
InsertTypeandUpdateTypeAND as the return value of new serialization helpers inExpressionBuilderandsqltemplate tag, users can now insert/update and serialize their JSON objects/arrays safely into JSON columns.Compilers/plugins can serialize the objects/arrays differently, as the value is passed around in a
ValueNodewith aserializedflag. The default serialization method is, well,JSON.stringify.If you want the non-type-safe old
JSONColumnType.. we don't encourage it, but you can continue usingJSONColumnType(until we decide to remove it) or just use:For a readonly
Json, use: